From de02a2450b2918c0680a9e115ab6060a226ca005 Mon Sep 17 00:00:00 2001
From: "Meredith L. Patterson" <mlp@thesmartpolitenerd.com>
Date: Tue, 10 Dec 2013 01:06:21 +0100
Subject: [PATCH] decrufted tests that rely on h_ch; still need to do h_action
and h_attr_bool
---
src/bindings/php/Tests/InTest.php | 3 +--
src/bindings/php/Tests/LeftTest.php | 1 -
src/bindings/php/Tests/MiddleTest.php | 1 -
src/bindings/php/Tests/NotInTest.php | 3 +--
src/bindings/php/Tests/RightTest.php | 1 -
src/bindings/php/Tests/WhitespaceTest.php | 1 -
6 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/src/bindings/php/Tests/InTest.php b/src/bindings/php/Tests/InTest.php
index 5c2ed8c4..6d1c5623 100644
--- a/src/bindings/php/Tests/InTest.php
+++ b/src/bindings/php/Tests/InTest.php
@@ -12,8 +12,7 @@ class InTest extends PHPUnit_Framework_TestCase
public function testSuccess()
{
$result = h_parse($this->parser, "b");
- // TODO: fixme when h_ch is fixed
- $this->assertEquals(98, $result);
+ $this->assertEquals("b", $result);
}
public function testFailure()
{
diff --git a/src/bindings/php/Tests/LeftTest.php b/src/bindings/php/Tests/LeftTest.php
index 1b2a906b..c671a808 100644
--- a/src/bindings/php/Tests/LeftTest.php
+++ b/src/bindings/php/Tests/LeftTest.php
@@ -12,7 +12,6 @@ class LeftTest extends PHPUnit_Framework_TestCase
public function testSuccess()
{
$result = h_parse($this->parser, "a ");
- // TODO fix these tests when h_ch is fixed
$this->assertEquals("a", $result);
}
public function testFailure()
diff --git a/src/bindings/php/Tests/MiddleTest.php b/src/bindings/php/Tests/MiddleTest.php
index 99dbb871..1ccb9da4 100644
--- a/src/bindings/php/Tests/MiddleTest.php
+++ b/src/bindings/php/Tests/MiddleTest.php
@@ -12,7 +12,6 @@ class MiddleTest extends PHPUnit_Framework_TestCase
public function testSuccess()
{
$result = h_parse($this->parser, " a ");
- // TODO fix these tests when h_ch is fixed
$this->assertEquals("a", $result);
}
public function testFailure()
diff --git a/src/bindings/php/Tests/NotInTest.php b/src/bindings/php/Tests/NotInTest.php
index 44a12a78..4a220d38 100644
--- a/src/bindings/php/Tests/NotInTest.php
+++ b/src/bindings/php/Tests/NotInTest.php
@@ -12,8 +12,7 @@ class NotInTest extends PHPUnit_Framework_TestCase
public function testSuccess()
{
$result = h_parse($this->parser, "d");
- // TODO: fixme when h_ch is fixed
- $this->assertEquals(100, $result);
+ $this->assertEquals("d", $result);
}
public function testFailure()
{
diff --git a/src/bindings/php/Tests/RightTest.php b/src/bindings/php/Tests/RightTest.php
index d5d44289..3c5b06e2 100644
--- a/src/bindings/php/Tests/RightTest.php
+++ b/src/bindings/php/Tests/RightTest.php
@@ -12,7 +12,6 @@ class RightTest extends PHPUnit_Framework_TestCase
public function testSuccess()
{
$result = h_parse($this->parser, " a");
- // TODO fix these tests when h_ch is fixed
$this->assertEquals("a", $result);
}
public function testFailure()
diff --git a/src/bindings/php/Tests/WhitespaceTest.php b/src/bindings/php/Tests/WhitespaceTest.php
index 73c4d453..96c2f380 100644
--- a/src/bindings/php/Tests/WhitespaceTest.php
+++ b/src/bindings/php/Tests/WhitespaceTest.php
@@ -17,7 +17,6 @@ class WhitespaceTest extends PHPUnit_Framework_TestCase
$result2 = h_parse($this->parser1, " a");
$result3 = h_parse($this->parser1, " a");
$result4 = h_parse($this->parser1, "\ta");
- // TODO fix these tests when h_ch is fixed
$this->assertEquals("a", $result1);
$this->assertEquals("a", $result2);
$this->assertEquals("a", $result3);
--
GitLab