From 3de6efd6bc82c0d395736013379f7e9561d912cb Mon Sep 17 00:00:00 2001
From: "Sven M. Hallberg" <pesco@khjk.org>
Date: Tue, 28 Mar 2023 17:44:10 +0000
Subject: [PATCH] revert to shadowing a variable instead of overwriting it
As indicated by the XXX, this line of code was never meant to be
considered as "proper", mainly because it allocates a new parser
that is never freed for every xref section in the file.
The reason that this line was introduced in place of the commented-out
original above it is that the latter does not bounds-check the offset
but h_seek() does. It was a quick and reliable way to make invalid
offsets fail the parse.
Anyway, creating a new HParser *p that incidentally shadows the
previous occurance was meant to signal that this is just a temporary
name that we need real quick (on the next line), not a "proper" variable,
and that it probably wasn't there to stay. So with that sense in mind, I
am putting it back.
Remove -Wshadow from CFLAGS.
---
Makefile | 2 +-
pdf.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 9189d7c..458eb46 100644
--- a/Makefile
+++ b/Makefile
@@ -1,4 +1,4 @@
-CFLAGS += -std=c99 -Wall -Werror -Wshadow -DLOG -D_POSIX_C_SOURCE=2
+CFLAGS += -std=c99 -Wall -Werror -DLOG -D_POSIX_C_SOURCE=2
# find our hammer build - adjust this to your needs
# i have, for instance, symlinks:
diff --git a/pdf.c b/pdf.c
index aea09f8..93a1efa 100644
--- a/pdf.c
+++ b/pdf.c
@@ -4927,7 +4927,7 @@ parse_xrefs(struct Env *aux)
for (;;) {
//res = h_parse(p_xref, input + offset, sz - offset);
- p = h_right(h_seek(offset * 8, SEEK_SET), p_xref); // XXX
+ HParser *p = h_right(h_seek(offset * 8, SEEK_SET), p_xref); // XXX
res = h_parse(p, input, sz);
if (res == NULL || res->ast == NULL || H_INDEX_TOKEN(res->ast, 0) == NULL) {
log_message(5, "VIOLATION[5]: error parsing xref section at "
--
GitLab