From dbc051aadc79ad96fa4c507fcba7d55437fa45b7 Mon Sep 17 00:00:00 2001 From: Pompolic <pompolic@special-circumstanc.es> Date: Mon, 26 Jul 2021 19:44:12 +0200 Subject: [PATCH] Fix off-by-one in partial ASCII85 group validation --- pdf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pdf.c b/pdf.c index ffd7874..fc31efb 100644 --- a/pdf.c +++ b/pdf.c @@ -466,7 +466,7 @@ act_a85partial2group(const HParseResult *p, void *u) bool validate_a85partial2group(HParseResult *p, void *u) { - return ((H_CAST_BYTES(p->ast).token[0] << 24) + (H_CAST_BYTES(p->ast).token[1] << 16)) <= A85GRPMAX; + return (H_CAST_BYTES(p->ast).token[0] << 24) <= A85GRPMAX; } HParsedToken * @@ -506,7 +506,7 @@ act_a85partial3group(const HParseResult *p, void *u) bool validate_a85partial3group(HParseResult *p, void *u) { - return ((H_CAST_BYTES(p->ast).token[0] << 24) + (H_CAST_BYTES(p->ast).token[1] << 16) + (H_CAST_BYTES(p->ast).token[2] << 8)) <= A85GRPMAX; + return ((H_CAST_BYTES(p->ast).token[0] << 24) + (H_CAST_BYTES(p->ast).token[1] << 16)) <= A85GRPMAX; } HParsedToken * -- GitLab