From b48e918e934cb62811181f2de4a1d591a9e6160b Mon Sep 17 00:00:00 2001 From: pompolic <pompolic@special-circumstanc.es> Date: Fri, 25 Nov 2022 14:44:34 +0100 Subject: [PATCH] Remove attempt to use parse_state_stack --- gdb-port/hammer-breakpoints.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/gdb-port/hammer-breakpoints.py b/gdb-port/hammer-breakpoints.py index 32b923e..9f225e1 100644 --- a/gdb-port/hammer-breakpoints.py +++ b/gdb-port/hammer-breakpoints.py @@ -84,11 +84,6 @@ class HDoParseRetBreakpoint(gdb.Breakpoint): # ast_manager.set_top_node(ret_val) # ast_manager.print_ast() - # warning: this is a mess - # This should go in the want_ast block below, logically, - # but return_from_h_do_parse() pops the last parse_state off the stack, but that's not the "snapshot" we want to pass in to ast_manager - # TODO: this is wrong. we need the parse_states from deeper into the call stack, and this only preserves the last one before return - parse_state_stack = top_level_parse.parse_state_stack.copy() top_level_parse.return_from_h_do_parse(parse_state, parser, ret_val) # Checking want_result_of() here avoids instantiating a HParseResult every time h_do_parse returns -- GitLab