diff --git a/.gitignore b/.gitignore index 721dcf9377a334d6d4f75617ea31df6f7c2ee639..570fbf81029442ab30ef3f4c6e691fa04146efd7 100644 --- a/.gitignore +++ b/.gitignore @@ -20,6 +20,7 @@ Session.vim *.gcov cscope.out build/ +libhammer.pc .sconsign.dblite *.os *.pyc diff --git a/src/allocator.c b/src/allocator.c index 258edfa5643a6123a4ca3ce640b06e89bd39a5a2..cc259e605c56573b506f39194793e804ab4bf8b6 100644 --- a/src/allocator.c +++ b/src/allocator.c @@ -18,6 +18,7 @@ #include <string.h> #include <stdint.h> #include <sys/types.h> +#include <setjmp.h> #include "hammer.h" #include "internal.h" @@ -42,17 +43,24 @@ struct HArena_ { size_t block_size; size_t used; size_t wasted; + + jmp_buf *except; }; +void* h_alloc(HAllocator* mm__, size_t size) { + void *p = mm__->alloc(mm__, size); + if(!p) + h_platform_errx(1, "memory allocation failed (%uB requested)\n", (unsigned int)size); + return p; +} + HArena *h_new_arena(HAllocator* mm__, size_t block_size) { if (block_size == 0) block_size = 4096; struct HArena_ *ret = h_new(struct HArena_, 1); - struct arena_link *link = (struct arena_link*)mm__->alloc(mm__, sizeof(struct arena_link) + block_size); - if (!link) { - // TODO: error-reporting -- let user know that arena link couldn't be allocated - return NULL; - } + struct arena_link *link = (struct arena_link*)h_alloc(mm__, sizeof(struct arena_link) + block_size); + assert(ret != NULL); + assert(link != NULL); memset(link, 0, sizeof(struct arena_link) + block_size); link->free = block_size; link->used = 0; @@ -62,9 +70,26 @@ HArena *h_new_arena(HAllocator* mm__, size_t block_size) { ret->used = 0; ret->mm__ = mm__; ret->wasted = sizeof(struct arena_link) + sizeof(struct HArena_) + block_size; + ret->except = NULL; return ret; } +void h_arena_set_except(HArena *arena, jmp_buf *except) +{ + arena->except = except; +} + +static void *alloc_block(HArena *arena, size_t size) +{ + void *block = arena->mm__->alloc(arena->mm__, size); + if (!block) { + if (arena->except) + longjmp(*arena->except, 1); + h_platform_errx(1, "memory allocation failed (%uB requested)\n", (unsigned int)size); + } + return block; +} + void* h_arena_malloc(HArena *arena, size_t size) { if (size <= arena->head->free) { // fast path.. @@ -79,22 +104,16 @@ void* h_arena_malloc(HArena *arena, size_t size) { // This involves some annoying casting... arena->used += size; arena->wasted += sizeof(struct arena_link*); - void* link = arena->mm__->alloc(arena->mm__, size + sizeof(struct arena_link*)); - if (!link) { - // TODO: error-reporting -- let user know that arena link couldn't be allocated - return NULL; - } + void* link = alloc_block(arena, size + sizeof(struct arena_link*)); + assert(link != NULL); memset(link, 0, size + sizeof(struct arena_link*)); *(struct arena_link**)link = arena->head->next; arena->head->next = (struct arena_link*)link; return (void*)(((uint8_t*)link) + sizeof(struct arena_link*)); } else { // we just need to allocate an ordinary new block. - struct arena_link *link = (struct arena_link*)arena->mm__->alloc(arena->mm__, sizeof(struct arena_link) + arena->block_size); - if (!link) { - // TODO: error-reporting -- let user know that arena link couldn't be allocated - return NULL; - } + struct arena_link *link = alloc_block(arena, sizeof(struct arena_link) + arena->block_size); + assert(link != NULL); memset(link, 0, sizeof(struct arena_link) + arena->block_size); link->free = arena->block_size - size; link->used = size; diff --git a/src/allocator.h b/src/allocator.h index 4a486936a058c0a619a83e7afdf0c5dfffc50d48..dc88af68f22895f584065a491463b3f8576c09e9 100644 --- a/src/allocator.h +++ b/src/allocator.h @@ -18,22 +18,12 @@ #ifndef HAMMER_ALLOCATOR__H__ #define HAMMER_ALLOCATOR__H__ #include <sys/types.h> +#include <setjmp.h> #ifdef __cplusplus extern "C" { #endif -// TODO(thequux): Turn this into an "HAllocatorVtable", and add a wrapper that also takes an environment pointer. -typedef struct HAllocator_ { - void* (*alloc)(struct HAllocator_* allocator, size_t size); - void* (*realloc)(struct HAllocator_* allocator, void* ptr, size_t size); - void (*free)(struct HAllocator_* allocator, void* ptr); -} HAllocator; - -typedef struct HArena_ HArena ; // hidden implementation - -HArena *h_new_arena(HAllocator* allocator, size_t block_size); // pass 0 for default... - #if defined __llvm__ # if __has_attribute(malloc) # define ATTR_MALLOC(n) __attribute__((malloc)) @@ -48,9 +38,23 @@ HArena *h_new_arena(HAllocator* allocator, size_t block_size); // pass 0 for def # define ATTR_MALLOC(n) #endif +// TODO(thequux): Turn this into an "HAllocatorVtable", and add a wrapper that also takes an environment pointer. +typedef struct HAllocator_ { + void* (*alloc)(struct HAllocator_* allocator, size_t size); + void* (*realloc)(struct HAllocator_* allocator, void* ptr, size_t size); + void (*free)(struct HAllocator_* allocator, void* ptr); +} HAllocator; + +void* h_alloc(HAllocator* allocator, size_t size) ATTR_MALLOC(2); + +typedef struct HArena_ HArena ; // hidden implementation + +HArena *h_new_arena(HAllocator* allocator, size_t block_size); // pass 0 for default... + void* h_arena_malloc(HArena *arena, size_t count) ATTR_MALLOC(2); void h_arena_free(HArena *arena, void* ptr); // For future expansion, with alternate memory managers. void h_delete_arena(HArena *arena); +void h_arena_set_except(HArena *arena, jmp_buf *except); typedef struct { size_t used; diff --git a/src/backends/glr.c b/src/backends/glr.c index e753ea55d938cc07582ceed83db92354cbacf68f..535dc2860c59018324893da1450cfc4ff4fadf8b 100644 --- a/src/backends/glr.c +++ b/src/backends/glr.c @@ -198,6 +198,16 @@ HParseResult *h_glr_parse(HAllocator* mm__, const HParser* parser, HInputStream* HArena *arena = h_new_arena(mm__, 0); // will hold the results HArena *tarena = h_new_arena(mm__, 0); // tmp, deleted after parse + // out-of-memory handling + jmp_buf except; + h_arena_set_except(arena, &except); + h_arena_set_except(tarena, &except); + if(setjmp(except)) { + h_delete_arena(arena); + h_delete_arena(tarena); + return NULL; + } + // allocate engine lists (will hold one engine per state) // these are swapped each iteration HSlist *engines = h_slist_new(tarena); diff --git a/src/backends/llk.c b/src/backends/llk.c index 0ab4610a29a1fcdefd1ca163ea2be8785b3ed0e6..4e8209b30f4aa7bd97f5df1c49202643d4efedd4 100644 --- a/src/backends/llk.c +++ b/src/backends/llk.c @@ -383,12 +383,20 @@ static HCountedArray *llk_parse_chunk_(HLLkState *s, const HParser* parser, HArena *arena = s->arena; HArena *tarena = s->tarena; HSlist *stack = s->stack; - HCountedArray *seq = s->seq; size_t kmax = table->kmax; - if(!seq) + if(!s->seq) return NULL; // parse already failed + // out-of-memory handling + jmp_buf except; + h_arena_set_except(arena, &except); + h_arena_set_except(tarena, &except); + if(setjmp(except)) + goto no_parse; + + HCountedArray *seq = s->seq; + if(s->win.length > 0) { append_win(kmax, s, chunk); stream = &s->win; @@ -527,12 +535,15 @@ static HCountedArray *llk_parse_chunk_(HLLkState *s, const HParser* parser, // since we started with a single nonterminal on the stack, seq should // contain exactly the parse result. assert(seq->used == 1); + + end: + h_arena_set_except(arena, NULL); + h_arena_set_except(tarena, NULL); return seq; no_parse: - h_delete_arena(arena); - s->arena = NULL; - return NULL; + seq = NULL; + goto end; need_input: if(stream->last_chunk) @@ -540,7 +551,7 @@ static HCountedArray *llk_parse_chunk_(HLLkState *s, const HParser* parser, if(tok) h_arena_free(arena, tok); // no result, yet h_slist_push(stack, x); // try this symbol again next time - return seq; + goto end; } static HParseResult *llk_parse_finish_(HAllocator *mm__, HLLkState *s) @@ -550,6 +561,8 @@ static HParseResult *llk_parse_finish_(HAllocator *mm__, HLLkState *s) if(s->seq) { assert(s->seq->used == 1); res = make_result(s->arena, s->seq->elements[0]); + } else { + h_delete_arena(s->arena); } h_delete_arena(s->tarena); @@ -582,6 +595,9 @@ bool h_llk_parse_chunk(HSuspendedParser *s, HInputStream *input) state->seq = llk_parse_chunk_(state, s->parser, input); + h_arena_set_except(state->arena, NULL); + h_arena_set_except(state->tarena, NULL); + return (state->seq == NULL || h_slist_empty(state->stack)); } diff --git a/src/backends/lr.c b/src/backends/lr.c index fb256c0bfafa0b6c53b32307bea64f61d4885919..f2ac4956d80358e51d35c0e70484013bbfde212a 100644 --- a/src/backends/lr.c +++ b/src/backends/lr.c @@ -388,6 +388,16 @@ HParseResult *h_lr_parse(HAllocator* mm__, const HParser* parser, HInputStream* HArena *tarena = h_new_arena(mm__, 0); // tmp, deleted after parse HLREngine *engine = h_lrengine_new(arena, tarena, table, stream); + // out-of-memory handling + jmp_buf except; + h_arena_set_except(arena, &except); + h_arena_set_except(tarena, &except); + if(setjmp(except)) { + h_delete_arena(arena); + h_delete_arena(tarena); + return NULL; + } + // iterate engine to completion while(h_lrengine_step(engine, h_lrengine_action(engine))); @@ -416,6 +426,16 @@ bool h_lr_parse_chunk(HSuspendedParser* s, HInputStream *stream) engine->input = *stream; bool run = true; + + // out-of-memory handling + jmp_buf except; + h_arena_set_except(engine->arena, &except); + h_arena_set_except(engine->tarena, &except); + if(setjmp(except)) { + run = false; // done immediately + assert(engine->state != HLR_SUCCESS); // h_parse_finish will return NULL + } + while(run) { // check input against table to determine which action to take const HLRAction *action = h_lrengine_action(engine); @@ -431,6 +451,9 @@ bool h_lr_parse_chunk(HSuspendedParser* s, HInputStream *stream) break; } + h_arena_set_except(engine->arena, NULL); + h_arena_set_except(engine->tarena, NULL); + *stream = engine->input; return !run; // done if engine no longer running } diff --git a/src/backends/packrat.c b/src/backends/packrat.c index abb198b02560e1bdec3d98211310f2e6e47da170..b7e47aef07422a1520849d94e5420b56e6112d79 100644 --- a/src/backends/packrat.c +++ b/src/backends/packrat.c @@ -254,6 +254,15 @@ static bool pos_equal(const void* key1, const void* key2) { HParseResult *h_packrat_parse(HAllocator* mm__, const HParser* parser, HInputStream *input_stream) { HArena * arena = h_new_arena(mm__, 0); + + // out-of-memory handling + jmp_buf except; + h_arena_set_except(arena, &except); + if(setjmp(except)) { + h_delete_arena(arena); + return NULL; + } + HParseState *parse_state = a_new_(arena, HParseState, 1); parse_state->cache = h_hashtable_new(arena, cache_key_equal, // key_equal_func cache_key_hash); // hash_func diff --git a/src/backends/regex.c b/src/backends/regex.c index f6494fa98afea084ab347511ec0f25dc0e11379c..f7dd98add85844366cca53aa96be31c596b4221c 100644 --- a/src/backends/regex.c +++ b/src/backends/regex.c @@ -52,11 +52,21 @@ HRVMTrace *invert_trace(HRVMTrace *trace) { void* h_rvm_run__m(HAllocator *mm__, HRVMProg *prog, const uint8_t* input, size_t len) { HArena *arena = h_new_arena(mm__, 0); - HSArray *heads_n = h_sarray_new(mm__, prog->length), // Both of these contain HRVMTrace*'s - *heads_p = h_sarray_new(mm__, prog->length); + HSArray *heads_a = h_sarray_new(mm__, prog->length), // Both of these contain HRVMTrace*'s + *heads_b = h_sarray_new(mm__, prog->length); HRVMTrace *ret_trace = NULL; + HParseResult *ret = NULL; + // out of memory handling + if(!arena || !heads_a || !heads_b) + goto end; + jmp_buf except; + h_arena_set_except(arena, &except); + if(setjmp(except)) + goto end; + + HSArray *heads_n = heads_a, *heads_p = heads_b; uint8_t *insn_seen = a_new(uint8_t, prog->length); // 0 -> not seen, 1->processed, 2->queued HRVMThread *ip_queue = a_new(HRVMThread, prog->length); size_t ipq_top; @@ -164,18 +174,19 @@ void* h_rvm_run__m(HAllocator *mm__, HRVMProg *prog, const uint8_t* input, size_ } // No accept was reached. match_fail: - if (ret_trace == NULL) { - // No match found; definite failure. - h_delete_arena(arena); - return NULL; + + h_arena_set_except(arena, NULL); // there should be no more allocs from this + if (ret_trace) { + // Invert the direction of the trace linked list. + ret_trace = invert_trace(ret_trace); + ret = run_trace(mm__, prog, ret_trace, input, len); + // NB: ret is in its own arena } - // Invert the direction of the trace linked list. - - ret_trace = invert_trace(ret_trace); - HParseResult *ret = run_trace(mm__, prog, ret_trace, input, len); - // ret is in its own arena - h_delete_arena(arena); + end: + if (arena) h_delete_arena(arena); + if (heads_a) h_sarray_free(heads_a); + if (heads_b) h_sarray_free(heads_b); return ret; } #undef PUSH_SVM @@ -203,6 +214,14 @@ HParseResult *run_trace(HAllocator *mm__, HRVMProg *orig_prog, HRVMTrace *trace, ctx.stack_capacity = 16; ctx.stack = h_new(HParsedToken*, ctx.stack_capacity); + // out of memory handling + if(!arena || !ctx.stack) + goto fail; + jmp_buf except; + h_arena_set_except(arena, &except); + if(setjmp(except)) + goto fail; + HParsedToken *tmp_res; HRVMTrace *cur; for (cur = trace; cur; cur = cur->next) { @@ -242,7 +261,7 @@ HParseResult *run_trace(HAllocator *mm__, HRVMProg *orig_prog, HRVMTrace *trace, break; case SVM_ACCEPT: assert(ctx.stack_count <= 1); - HParseResult *res = a_new(HParseResult, 1); + HParseResult *res = a_new(HParseResult, 1); if (ctx.stack_count == 1) { res->ast = ctx.stack[0]; } else { @@ -250,11 +269,14 @@ HParseResult *run_trace(HAllocator *mm__, HRVMProg *orig_prog, HRVMTrace *trace, } res->bit_length = cur->input_pos * 8; res->arena = arena; + h_arena_set_except(arena, NULL); + h_free(ctx.stack); return res; } } fail: - h_delete_arena(arena); + if (arena) h_delete_arena(arena); + if (ctx.stack) h_free(ctx.stack); return NULL; } diff --git a/src/bitwriter.c b/src/bitwriter.c index 74e273448aded2ae40ec99666f230447054c0dd0..bcc21dd308a743a7dd98a6bc52364f75f2d75328 100644 --- a/src/bitwriter.c +++ b/src/bitwriter.c @@ -12,10 +12,8 @@ HBitWriter *h_bit_writer_new(HAllocator* mm__) { HBitWriter *writer = h_new(HBitWriter, 1); memset(writer, 0, sizeof(*writer)); - writer->buf = mm__->alloc(mm__, writer->capacity = 8); - if (!writer) { - return NULL; - } + writer->buf = h_alloc(mm__, writer->capacity = 8); + assert(writer != NULL); memset(writer->buf, 0, writer->capacity); writer->mm__ = mm__; writer->flags = BYTE_BIG_ENDIAN | BIT_BIG_ENDIAN; diff --git a/src/datastructures.c b/src/datastructures.c index 0feeb2176b0422471f65a053a7ef9a716af1821c..af8477be36123a53506871827d4dae13d8c9002b 100644 --- a/src/datastructures.c +++ b/src/datastructures.c @@ -25,11 +25,12 @@ HCountedArray *h_carray_new(HArena * arena) { void h_carray_append(HCountedArray *array, void* item) { if (array->used >= array->capacity) { - HParsedToken **elements = h_arena_malloc(array->arena, (array->capacity *= 2) * sizeof(HCountedArray*)); + HParsedToken **elements = h_arena_malloc(array->arena, (array->capacity *= 2) * sizeof(void*)); for (size_t i = 0; i < array->used; i++) elements[i] = array->elements[i]; for (size_t i = array->used; i < array->capacity; i++) elements[i] = 0; + h_arena_free(array->arena, array->elements); array->elements = elements; } array->elements[array->used++] = item; diff --git a/src/internal.h b/src/internal.h index 776f636811183a4b3e19de9de8c8ce5b2b66f27d..10db4b20f429283bbf0aa99928487b2754379d91 100644 --- a/src/internal.h +++ b/src/internal.h @@ -49,7 +49,7 @@ rtype_t name##__m(HAllocator* mm__) // Functions with arguments are difficult to forward cleanly. Alas, we will need to forward them manually. -#define h_new(type, count) ((type*)(mm__->alloc(mm__, sizeof(type)*(count)))) +#define h_new(type, count) ((type*)(h_alloc(mm__, sizeof(type)*(count)))) #define h_free(addr) (mm__->free(mm__, (addr))) #ifndef __cplusplus diff --git a/src/parsers/bind.c b/src/parsers/bind.c index 7fa821dc7d9837ef717114e2245d7c31fa80cacb..808df9742bc6e7a1bb6c93a838f9f69903d036e0 100644 --- a/src/parsers/bind.c +++ b/src/parsers/bind.c @@ -4,7 +4,6 @@ typedef struct { const HParser *p; HContinuation k; void *env; - HAllocator *mm__; } BindEnv; // an HAllocator backed by an HArena @@ -39,20 +38,15 @@ static HParseResult *parse_bind(void *be_, HParseState *state) { if(!res) return NULL; - // create a temporary arena allocator for the continuation - HArena *arena = h_new_arena(be->mm__, 0); - ArenaAllocator aa = {{aa_alloc, aa_realloc, aa_free}, arena}; + // create a wrapper arena allocator for the continuation + ArenaAllocator aa = {{aa_alloc, aa_realloc, aa_free}, state->arena}; HParser *kx = be->k((HAllocator *)&aa, res->ast, be->env); if(!kx) { - h_delete_arena(arena); return NULL; } - res = h_do_parse(kx, state); - - h_delete_arena(arena); - return res; + return h_do_parse(kx, state); } static const HParserVtable bind_vt = { @@ -76,7 +70,6 @@ HParser *h_bind__m(HAllocator *mm__, be->p = p; be->k = k; be->env = env; - be->mm__ = mm__; return h_new_parser(mm__, &bind_vt, be); } diff --git a/src/parsers/many.c b/src/parsers/many.c index 6496bbe61860a9a20c83b2eff6ab007c630a3e77..071e3fcd2d30ed35f4622962751ebc63bea3d37c 100644 --- a/src/parsers/many.c +++ b/src/parsers/many.c @@ -10,7 +10,10 @@ typedef struct { static HParseResult *parse_many(void* env, HParseState *state) { HRepeat *env_ = (HRepeat*) env; - HCountedArray *seq = h_carray_new_sized(state->arena, (env_->count > 0 ? env_->count : 4)); + size_t size = env_->count; + if(size <= 0) size = 4; + if(size > 1024) size = 1024; // let's try parsing some elements first... + HCountedArray *seq = h_carray_new_sized(state->arena, size); size_t count = 0; HInputStream bak; while (env_->min_p || env_->count > count) { diff --git a/src/parsers/sequence.c b/src/parsers/sequence.c index 30de34a4885d7c56afdf6a0f00e0d34167a08dc2..55c0c8885573ef7779714efd49eaf64cc59ac878 100644 --- a/src/parsers/sequence.c +++ b/src/parsers/sequence.c @@ -117,26 +117,33 @@ HParser* h_sequence__v(HParser* p, va_list ap) { } HParser* h_sequence__mv(HAllocator* mm__, HParser *p, va_list ap_) { - va_list ap; - size_t len = 0; - const HParser *arg; - va_copy(ap, ap_); - do { - len++; - arg = va_arg(ap, HParser *); - } while (arg); - va_end(ap); HSequence *s = h_new(HSequence, 1); - s->p_array = h_new(HParser *, len); - - va_copy(ap, ap_); - s->p_array[0] = p; - for (size_t i = 1; i < len; i++) { - s->p_array[i] = va_arg(ap, HParser *); - } while (arg); - va_end(ap); + s->len = 0; + + if(p) { + // non-empty sequence + const HParser *arg; + size_t len = 0; + va_list ap; + + va_copy(ap, ap_); + do { + len++; + arg = va_arg(ap, HParser *); + } while (arg); + va_end(ap); + s->p_array = h_new(HParser *, len); + + va_copy(ap, ap_); + s->p_array[0] = p; + for (size_t i = 1; i < len; i++) { + s->p_array[i] = va_arg(ap, HParser *); + } while (arg); + va_end(ap); + + s->len = len; + } - s->len = len; return h_new_parser(mm__, &sequence_vt, s); } diff --git a/src/pprint.c b/src/pprint.c index 11ec3d67411df66043ddd7880edeb22cb5d7db51..9c7c6522c0a201cf544ffaea3227510fec4bf827 100644 --- a/src/pprint.c +++ b/src/pprint.c @@ -186,13 +186,11 @@ static void unamb_sub(const HParsedToken* tok, struct result_buf *buf) { char* h_write_result_unamb(const HParsedToken* tok) { struct result_buf buf = { - .output = (&system_allocator)->alloc(&system_allocator, 16), + .output = h_alloc(&system_allocator, 16), .len = 0, .capacity = 16 }; - if (!buf.output) { - return NULL; - } + assert(buf.output != NULL); unamb_sub(tok, &buf); append_buf_c(&buf, 0); return buf.output; diff --git a/src/registry.c b/src/registry.c index 2ebac1a94ad37a501c7c10a50c3eb6a45fc74dd0..d905320bbdf6131e5ab449c525086e4b1205a28b 100644 --- a/src/registry.c +++ b/src/registry.c @@ -46,10 +46,8 @@ static int compare_entries(const void* v1, const void* v2) { } HTokenType h_allocate_token_type(const char* name) { - Entry* new_entry = (&system_allocator)->alloc(&system_allocator, sizeof(*new_entry)); - if (!new_entry) { - return TT_INVALID; - } + Entry* new_entry = h_alloc(&system_allocator, sizeof(*new_entry)); + assert(new_entry != NULL); new_entry->name = name; new_entry->value = 0; Entry* probe = *(Entry**)tsearch(new_entry, &tt_registry, compare_entries); diff --git a/src/t_misc.c b/src/t_misc.c index 92c2b326471d48a82fcae8f110d1febad58c6fe3..04ce96c1f6153de2b196be2dbacda55f8e6d9e23 100644 --- a/src/t_misc.c +++ b/src/t_misc.c @@ -1,5 +1,6 @@ #include <glib.h> #include <string.h> +#include <sys/resource.h> #include "test_suite.h" #include "hammer.h" @@ -29,7 +30,54 @@ static void test_tt_registry(void) { g_check_cmp_int32(h_get_token_type_number("com.upstandinghackers.test.unkown_token_type"), ==, 0); } +// test out-of-memory handling with a selectively failing allocator +static void *fail_alloc(HAllocator *mm__, size_t size) { + if(size - 0xdead <= 0x30) // allow for overhead of arena link structure + return NULL; + return system_allocator.alloc(&system_allocator, size); +} +static void *fail_realloc(HAllocator *mm__, void *ptr, size_t size) { + return system_allocator.realloc(&system_allocator, ptr, size); +} +static void fail_free(HAllocator *mm__, void *ptr) { + return system_allocator.free(&system_allocator, ptr); +} +static HAllocator fail_allocator = {fail_alloc, fail_realloc, fail_free}; +static HParsedToken *act_oom(const HParseResult *r, void *user) { + void *buf = h_arena_malloc(r->arena, 0xdead); + assert(buf != NULL); + return NULL; // succeed with null token +} +static void test_oom(void) { + HParser *p = h_action(h_ch('x'), act_oom, NULL); + // this should always fail, but never crash + + // sanity-check: parses should succeed with the normal allocator... + g_check_parse_ok(p, PB_PACKRAT, "x",1); + g_check_parse_ok(p, PB_REGULAR, "x",1); + g_check_parse_ok(p, PB_LLk, "x",1); + g_check_parse_ok(p, PB_LALR, "x",1); + g_check_parse_ok(p, PB_GLR, "x",1); + //XXX g_check_parse_chunks_ok(p, PB_REGULAR, "",0, "x",1); + g_check_parse_chunks_ok(p, PB_LLk, "",0, "x",1); + g_check_parse_chunks_ok(p, PB_LALR, "",0, "x",1); + //XXX g_check_parse_chunks_ok(p, PB_GLR, "",0, "x",1); + + // ...and fail gracefully with the broken one + HAllocator *mm__ = &fail_allocator; + g_check_parse_failed__m(mm__, p, PB_PACKRAT, "x",1); + g_check_parse_failed__m(mm__, p, PB_REGULAR, "x",1); + g_check_parse_failed__m(mm__, p, PB_LLk, "x",1); + g_check_parse_failed__m(mm__, p, PB_LALR, "x",1); + g_check_parse_failed__m(mm__, p, PB_GLR, "x",1); + //XXX g_check_parse_chunks_failed__m(mm__, p, PB_REGULAR, "",0, "x",1); + g_check_parse_chunks_failed__m(mm__, p, PB_LLk, "",0, "x",1); + g_check_parse_chunks_failed__m(mm__, p, PB_LALR, "",0, "x",1); + //XXX g_check_parse_chunks_failed__m(mm__, p, PB_GLR, "",0, "x",1); +} + void register_misc_tests(void) { g_test_add_func("/core/misc/tt_user", test_tt_user); g_test_add_func("/core/misc/tt_registry", test_tt_registry); + g_test_add_func("/core/misc/oom", test_oom); } diff --git a/src/t_parser.c b/src/t_parser.c index c42eca91321c241a1987b99116c8c90deefbdf64..331d2629018b40717bf49309ba0b561ce7a618a3 100644 --- a/src/t_parser.c +++ b/src/t_parser.c @@ -241,6 +241,7 @@ static void test_nothing_p(gconstpointer backend) { static void test_sequence(gconstpointer backend) { const HParser *sequence_1 = h_sequence(h_ch('a'), h_ch('b'), NULL); const HParser *sequence_2 = h_sequence(h_ch('a'), h_whitespace(h_ch('b')), NULL); + const HParser *sequence_3 = h_sequence(NULL, NULL); // second NULL is to silence GCC g_check_parse_match(sequence_1, (HParserBackend)GPOINTER_TO_INT(backend), "ab", 2, "(u0x61 u0x62)"); g_check_parse_failed(sequence_1, (HParserBackend)GPOINTER_TO_INT(backend), "a", 1); @@ -248,6 +249,7 @@ static void test_sequence(gconstpointer backend) { g_check_parse_match(sequence_2, (HParserBackend)GPOINTER_TO_INT(backend), "ab", 2, "(u0x61 u0x62)"); g_check_parse_match(sequence_2, (HParserBackend)GPOINTER_TO_INT(backend), "a b", 3, "(u0x61 u0x62)"); g_check_parse_match(sequence_2, (HParserBackend)GPOINTER_TO_INT(backend), "a b", 4, "(u0x61 u0x62)"); + g_check_parse_match(sequence_3, (HParserBackend)GPOINTER_TO_INT(backend), "", 0, "()"); } static void test_choice(gconstpointer backend) { diff --git a/src/test_suite.h b/src/test_suite.h index 49f13cf81c50864eb8ae03ed705f582a7dd1ca0f..83359f9ec0a623f0c9f7ae5fa69175b94d6a98a8 100644 --- a/src/test_suite.h +++ b/src/test_suite.h @@ -78,29 +78,24 @@ } while(0) -// TODO: replace uses of this with g_check_parse_failed -#define g_check_failed(res) do { \ - const HParseResult *result = (res); \ - if (NULL != result) { \ - g_test_message("Check failed: shouldn't have succeeded, but did"); \ - g_test_fail(); \ - } \ - } while(0) - -#define g_check_parse_failed(parser, backend, input, inp_len) do { \ - int skip = h_compile((HParser *)(parser), (HParserBackend)backend, NULL); \ +#define g_check_parse_failed__m(mm__, parser, backend, input, inp_len) do { \ + int skip = h_compile__m(mm__, (HParser *)(parser), (HParserBackend)backend, NULL); \ if(skip != 0) { \ g_test_message("Compile failed"); \ g_test_fail(); \ break; \ } \ - const HParseResult *result = h_parse(parser, (const uint8_t*)input, inp_len); \ + HParseResult *result = h_parse__m(mm__, parser, (const uint8_t*)input, inp_len); \ if (NULL != result) { \ + h_parse_result_free(result); \ g_test_message("Check failed: shouldn't have succeeded, but did"); \ g_test_fail(); \ } \ } while(0) +#define g_check_parse_failed(p, be, input, len) \ + g_check_parse_failed__m(&system_allocator, p, be, input, len) + #define g_check_parse_ok(parser, backend, input, inp_len) do { \ int skip = h_compile((HParser *)(parser), (HParserBackend) backend, NULL); \ if(skip) { \ @@ -119,7 +114,7 @@ "Inefficiency: %5f%%", \ stats.used, stats.wasted, \ stats.wasted * 100. / (stats.used+stats.wasted)); \ - h_delete_arena(res->arena); \ + h_parse_result_free(res); \ } \ } while(0) @@ -144,22 +139,22 @@ "Inefficiency: %5f%%", \ stats.used, stats.wasted, \ stats.wasted * 100. / (stats.used+stats.wasted)); \ - h_delete_arena(res->arena); \ + h_parse_result_free(res); \ } \ } while(0) -#define g_check_parse_chunks_failed(parser, backend, chunk1, c1_len, chunk2, c2_len) do { \ - int skip = h_compile((HParser *)(parser), (HParserBackend)backend, NULL); \ +#define g_check_parse_chunks_failed__m(mm__, parser, backend, chunk1, c1_len, chunk2, c2_len) do { \ + int skip = h_compile__m(mm__, (HParser *)(parser), (HParserBackend)backend, NULL); \ if(skip) { \ g_test_message("Compile failed"); \ g_test_fail(); \ break; \ } \ - g_check_parse_chunks_failed_(parser, chunk1, c1_len, chunk2, c2_len); \ + g_check_parse_chunks_failed___m(mm__, parser, chunk1, c1_len, chunk2, c2_len); \ } while(0) -#define g_check_parse_chunks_failed_(parser, chunk1, c1_len, chunk2, c2_len) do { \ - HSuspendedParser *s = h_parse_start(parser); \ +#define g_check_parse_chunks_failed___m(mm__, parser, chunk1, c1_len, chunk2, c2_len) do { \ + HSuspendedParser *s = h_parse_start__m(mm__, parser); \ if(!s) { \ g_test_message("Chunk-wise parsing not available"); \ g_test_fail(); \ @@ -167,13 +162,54 @@ } \ h_parse_chunk(s, (const uint8_t*)chunk1, c1_len); \ h_parse_chunk(s, (const uint8_t*)chunk2, c2_len); \ - const HParseResult *res = h_parse_finish(s); \ + HParseResult *res = h_parse_finish(s); \ if (NULL != res) { \ + h_parse_result_free(res); \ g_test_message("Check failed: shouldn't have succeeded, but did"); \ g_test_fail(); \ } \ } while(0) +#define g_check_parse_chunks_failed(p, be, c1, c1_len, c2, c2_len) \ + g_check_parse_chunks_failed__m(&system_allocator, p, be, c1, c1_len, c2, c2_len) + +#define g_check_parse_chunks_failed_(p, c1, c1_len, c2, c2_len) \ + g_check_parse_chunks_failed___m(&system_allocator, p, c1, c1_len, c2, c2_len) + +#define g_check_parse_chunks_ok(parser, backend, chunk1, c1_len, chunk2, c2_len) do { \ + int skip = h_compile((HParser *)(parser), (HParserBackend)backend, NULL); \ + if(skip) { \ + g_test_message("Compile failed"); \ + g_test_fail(); \ + break; \ + } \ + g_check_parse_chunks_ok_(parser, chunk1, c1_len, chunk2, c2_len); \ + } while(0) + +#define g_check_parse_chunks_ok_(parser, chunk1, c1_len, chunk2, c2_len) do { \ + HSuspendedParser *s = h_parse_start(parser); \ + if(!s) { \ + g_test_message("Chunk-wise parsing not available"); \ + g_test_fail(); \ + break; \ + } \ + h_parse_chunk(s, (const uint8_t*)chunk1, c1_len); \ + h_parse_chunk(s, (const uint8_t*)chunk2, c2_len); \ + HParseResult *res = h_parse_finish(s); \ + if (!res) { \ + g_test_message("Parse failed on line %d", __LINE__); \ + g_test_fail(); \ + } else { \ + HArenaStats stats; \ + h_allocator_stats(res->arena, &stats); \ + g_test_message("Parse used %zd bytes, wasted %zd bytes. " \ + "Inefficiency: %5f%%", \ + stats.used, stats.wasted, \ + stats.wasted * 100. / (stats.used+stats.wasted)); \ + h_parse_result_free(res); \ + } \ + } while(0) + #define g_check_parse_chunks_match(parser, backend, chunk1, c1_len, chunk2, c2_len, result) do { \ int skip = h_compile((HParser *)(parser), (HParserBackend) backend, NULL); \ if(skip) { \ @@ -207,7 +243,7 @@ "Inefficiency: %5f%%", \ stats.used, stats.wasted, \ stats.wasted * 100. / (stats.used+stats.wasted)); \ - h_delete_arena(res->arena); \ + h_parse_result_free(res); \ } \ } while(0)