From e5c8a0a5c4ecc04447bdc57925aecf296ea0ee2c Mon Sep 17 00:00:00 2001
From: "Sven M. Hallberg" <pesco@khjk.org>
Date: Fri, 21 Feb 2020 19:54:54 +0100
Subject: [PATCH] add regression test for issue 83
https://gitlab.special-circumstanc.es/hammer/hammer/issues/83
---
src/t_regression.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/src/t_regression.c b/src/t_regression.c
index 7a04bc6e..b276f320 100644
--- a/src/t_regression.c
+++ b/src/t_regression.c
@@ -384,6 +384,30 @@ static void test_issue91() {
g_check_cmp_int(r, ==, -2);
}
+static void test_issue83() {
+ HParser *p = h_sequence(h_sequence(NULL, NULL), h_nothing_p(), NULL);
+ /*
+ * A -> B
+ * B -> C D
+ * C -> ""
+ * D -x
+ *
+ * (S) -> 0B1
+ * 0B1 -> 0C2 2D3
+ * 0C2 -> "" (*) h_follow()
+ * 2D3 -x
+ */
+
+ /*
+ * similar to issue 91, this would cause the same assertion failure, but for
+ * a different reason. the follow set of 0C2 above is equal to the first set
+ * of 2D3, but 2D3 is an empty choice. The first set of an empty choice
+ * is legitimately empty. the asserting in h_lalr_compile() missed this case.
+ */
+ int r = h_compile(p, PB_LALR, NULL);
+ g_check_cmp_int(r, ==, 0);
+}
+
void register_regression_tests(void) {
g_test_add_func("/core/regression/bug118", test_bug118);
g_test_add_func("/core/regression/seq_index_path", test_seq_index_path);
@@ -397,4 +421,5 @@ void register_regression_tests(void) {
g_test_add_func("/core/regression/flatten_null", test_flatten_null);
//XXX g_test_add_func("/core/regression/ast_length_index", test_ast_length_index);
g_test_add_func("/core/regression/issue91", test_issue91);
+ g_test_add_func("/core/regression/issue83", test_issue83);
}
--
GitLab